Make sure that multi-options are checked after splitting them with shlex#2130
Merged
Make sure that multi-options are checked after splitting them with shlex#2130
shlex#2130Conversation
…hlex` Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
Byron
force-pushed
the
fix-multi-options
branch
from
81f92e6 to
c9a2678
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses the GitPython security advisory GHSA-x2qx-6953-8485 by ensuring “multi-options” are validated for unsafe flags after they are split via shlex, preventing unsafe options from being hidden inside a single multi-option string.
Changes:
- Update clone option validation to run
check_unsafe_optionsagainst theshlex-split multi-options list. - Add regression tests for
Repo.clone,Repo.clone_from, andSubmodule.updateto confirm unsafe options are caught when embedded in a combined multi-option payload.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
git/repo/base.py |
Validates unsafe clone options against the split multi args instead of the raw multi_options strings. |
test/test_clone.py |
Adds tests ensuring unsafe options are rejected after splitting multi_options payload strings. |
test/test_submodule.py |
Adds a test ensuring submodule update clone options are checked after splitting combined payloads. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for https://github.com/gitpython-developers/GitPython/security/advisories/GHSA-x2qx-6953-8485